batch anonymous usage statistics calls #2089
Merged
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2008
Move tracking to use POST instead of GET, and set up batching. I set it to 30 because the default of 10 seemed small for bigger projects, but 100 seemed too big.
This resulted in a substantial performance improvement when running dbt in locations far away from the US, and even a small improvement nearby. A run with 100 models from Mumbai went from ~78s to ~12s (with tracking disabled, ~3s). There are noticeable 1-2s stops every 30 models or so because the snowflake tracker blocks all threads from tracking while making the http call, but I think that's fine. On a US-based instance, performance was pretty much the same - maybe a slight improvement?